Skip to content

feat: delete meeting for me [WPB-27932] - #5236

Merged
saleniuk merged 4 commits into
developfrom
feat/meeting-delete-for-me
Sep 2, 2026
Merged

feat: delete meeting for me [WPB-27932]#5236
saleniuk merged 4 commits into
developfrom
feat/meeting-delete-for-me

Conversation

@saleniuk

@saleniuk saleniuk commented Aug 31, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

https://wearezeta.atlassian.net/browse/WPB-27932

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Meeting participant who is not a creator, needs to have an option to "delete meeting for me", which basically makes this user to leave the underlying conversation.

Dependencies (Optional)

Needs releases with:

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

User A creates a meeting and adds user B as a participant, then user B can "delete meeting for me" and it disappears from their meeting list.

Attachments (Optional)

delete.for.me.mov

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions

github-actions Bot commented Aug 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Test Results

2 641 tests  +2   2 641 ✅ +2   1m 51s ⏱️ +21s
  336 suites ±0       0 💤 ±0 
  336 files   ±0       0 ❌ ±0 

Results for commit 465ffdf. ± Comparison against base commit e73dcbe.

This pull request removes 4 and adds 6 tests. Note that renamed tests count towards both. 
com.wire.android.feature.meetings.ui.options.MeetingOptionsMenuViewModelTest ‑ givenFailure_whenDeletingMeeting_thenFailureMessageIsSentAndDialogIsDismissed()
com.wire.android.feature.meetings.ui.options.MeetingOptionsMenuViewModelTest ‑ givenFutureMeeting_andSelfUserIsMember_whenObserving_thenEditAndDeleteIsNotAvailable()
com.wire.android.feature.meetings.ui.options.MeetingOptionsMenuViewModelTest ‑ givenPastMeeting_andSelfUserIsMember_whenObserving_thenEditAndDeleteIsNotAvailable()
com.wire.android.feature.meetings.ui.options.MeetingOptionsMenuViewModelTest ‑ givenSuccess_whenDeletingMeeting_thenSuccessMessageIsSentAndDialogIsDismissed()

com.wire.android.feature.meetings.ui.options.MeetingOptionsMenuViewModelTest ‑ givenFailure_whenDeletingMeetingForEveryone_thenFailureMessageIsSentAndDialogIsDismissed()
com.wire.android.feature.meetings.ui.options.MeetingOptionsMenuViewModelTest ‑ givenFailure_whenDeletingMeetingForMe_thenFailureMessageIsSentAndDialogIsDismissed()
com.wire.android.feature.meetings.ui.options.MeetingOptionsMenuViewModelTest ‑ givenFutureMeeting_andSelfUserIsMember_whenObserving_thenDeleteForMeIsAvailable()
com.wire.android.feature.meetings.ui.options.MeetingOptionsMenuViewModelTest ‑ givenPastMeeting_andSelfUserIsMember_whenObserving_thenEditIsNotAvailableAndDeleteForMeIsAvailable()
com.wire.android.feature.meetings.ui.options.MeetingOptionsMenuViewModelTest ‑ givenSuccess_whenDeletingMeetingForEveryone_thenSuccessMessageIsSentAndDialogIsDismissed()
com.wire.android.feature.meetings.ui.options.MeetingOptionsMenuViewModelTest ‑ givenSuccess_whenDeletingMeetingForMe_thenSuccessMessageIsSentAndDialogIsDismissed()

♻️ This comment has been updated with latest results.

@codecov

codecov Bot commented Aug 31, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.28%. Comparing base (e73dcbe) to head (465ffdf).

Files with missing lines Patch % Lines
...meetings/ui/options/MeetingOptionsMenuViewModel.kt 86.36% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #5236      +/-   ##
===========================================
+ Coverage    52.26%   52.28%   +0.02%     
===========================================
  Files          745      745              
  Lines        25897    25911      +14     
  Branches      4235     4236       +1     
===========================================
+ Hits         13534    13547      +13     
- Misses       11066    11067       +1     
  Partials      1297     1297
Files with missing lines Coverage Δ
...feature/meetings/ui/options/DeleteMeetingDialog.kt 100.00% <100.00%> (ø)
...tings/ui/options/MeetingOptionsModalSheetLayout.kt 0.00% <ø> (ø)
...meetings/ui/options/MeetingOptionsMenuViewModel.kt 72.09% <86.36%> (+3.17%) ⬆️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e73dcbe...465ffdf. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@saleniuk
saleniuk added this pull request to the merge queue Sep 2, 2026
Merged via the queue into develop with commit ee9b66a Sep 2, 2026
24 of 26 checks passed
@saleniuk
saleniuk deleted the feat/meeting-delete-for-me branch September 2, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbakhtiarov sbakhtiarov sbakhtiarov approved these changes
@ohassine ohassine ohassine approved these changes

Assignees

@saleniuk saleniuk

Labels

size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@saleniuk @sbakhtiarov @ohassine